Welcome to OGeek Q&A Community for programmer and developer-Open, Learning and Share
Welcome To Ask or Share your Answers For Others

Categories

0 votes
1.5k views
in Technique[技术] by (71.8m points)

multithreading - Threading in C#: How to keep loop-index thread-safe?

In the following example, it seems that the index i of the for-loop is modified independently by each thread leading to strange values of i (multiples, even values larger than System.Environment.ProcessorCount-1) in DoWork_Threaded()

How are multithreaded loops properly done in C# ?

// Prepare all threads
Thread[] threads = new Thread[System.Environment.ProcessorCount];

// Start all threads
for (int i = 0; i < System.Environment.ProcessorCount; i++)
{
   threads[i] = new Thread(() => DoWork_Threaded(i));
   threads[i].Start();
}

// Wait for completion of all threads
for (int i = 0; i < System.Environment.ProcessorCount; i++)
{
   threads[i].Join();
}
See Question&Answers more detail:os

与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
Welcome To Ask or Share your Answers For Others

1 Reply

0 votes
by (71.8m points)

First of all, rather than rolling your own thread scheduling service, why not use the task parallel library? It already has logic that determines the number of processors to schedule threads onto.

To answer your actual question, you are closing over a loop variable. See my article on why that is wrong:

https://ericlippert.com/2009/11/12/closing-over-the-loop-variable-considered-harmful-part-one/

In short: i is a variable and variables change. When your lambda executes, it executes with the current value of i, not the value it used to have when the delegate was created.


与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
OGeek|极客中国-欢迎来到极客的世界,一个免费开放的程序员编程交流平台!开放,进步,分享!让技术改变生活,让极客改变未来! Welcome to OGeek Q&A Community for programmer and developer-Open, Learning and Share
Click Here to Ask a Question

...