c++ - Algorithm crashing

Question

int function(int A[], int n)
{

    int i = 0;
    int sum = 0;
    int amount = 0;

    while(i<n) {
        if(A[i] > 0) {
            sum=sum+A[i];
            amount++;
        }
        else {
            i++;
        }
    }
    while(!(i<n)) {
        if(ile>0){
            return sum/amount;
        } else {
            return 0;
        }
    }

}

I am generating random array of numbers between 0-10 , Im trying to use this with this algorithm, but all the time im getting result 6422260. Can someone tell me how should I approach this?

   int n;
    cin >> n;
    int arr[n];
    srand(time(NULL));

    for (int i = 0; i < 10; i++)
    {
     arr[i] = rand() % 10;
    }
    function(arr, n);

question from:https://stackoverflow.com/questions/65857506/algorithm-crashing

Answer 1

Here is a solution to your problem:

#include <random>
#include <iostream>

void fill(int arr[]); 
int random(int from, int to);

using namespace std;

int main(void)
{
    int arr[10];
    fill(arr);
    for(int i = 0; i<10; i++)
        printf("%d ", arr[i]);
 
    return 0;
}

void fill(int arr[]){
    for(int i=0;i<(*(&arr + 1) - arr);i++){
        arr[i] = random(0, 10);//adjust accordngly
    }
}

int random(int from, int to){
    std::random_device dev;
    std::mt19937 rng(dev());
    std::uniform_int_distribution<std::mt19937::result_type> dist6(from, to); // distribution in range [from, to]
    return dist6(rng);
}

Your problem is you are not generating random numbers your algorithm is generating the same set of numbers! You need a logic to generate random number. Usually they are generated from system time ...

Attribution : https://stackoverflow.com/a/13445752/14911094